[
https://issues.apache.org/jira/browse/TEZ-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028469#comment-14028469
]
Bikas Saha commented on TEZ-1172:
---------------------------------
This should be if multiple input initializers are specified. Multiple inputs
without initializers should not need a custom manager right? e.g. input payload
could be enough to determine each input since inputs know their task index from
the context. Or the inputs may contact something else to get work info.
{code}+ if (vertex.getInputs().size() > 1 &&
vertex.getVertexManagerPlugin() == null) {
+ throw new IllegalStateException(
+ "When using multiple Inputs on a vertex, a custom
VertexManagerPlugin must be used");
+ }{code}
Same comment as above. Also how about the -1 numTasks requirement?
{code}+ * Note: If more than one RootInput is required on a vertex, a custom
vertex manager
+ * must also be specified to correctly route events and determine
parallelism.
+ * {code}
Shouldn't this test
1) have -1 tasks - If yes, we probably need another test that checks that >=0
tasks errors out when specifying multiple inputs with initializers.
2) only error out when input initializers are present.
{code}+ public void testMultipleRootInputs1() {code}
Same comment as above for input initializers. Btw, hasnt the client already
checked for this?
{code}+ if (inputs.size() > 1 && !vertexPlan.hasVertexManagerPlugin()) {
+ throw new IllegalStateException(
+ "Must specify a custom vertex manager if setting multiple Inputs on
a vertex");
+ }{code}
> Allow multiple Root Input initializers to be specified per Vertex
> -----------------------------------------------------------------
>
> Key: TEZ-1172
> URL: https://issues.apache.org/jira/browse/TEZ-1172
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-1172.1.txt, TEZ-1172.2.txt
>
>
> The default VertexManager in Tez for this handles only 1 RootInput - since it
> doesn't know how to combine multiple different Inputs. However, if a custom
> vertex manager plugin is specified by users - it should be possible to
> specify multiple RootInputs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
