[ 
https://issues.apache.org/jira/browse/TEZ-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041129#comment-14041129
 ] 

Siddharth Seth commented on TEZ-1119:
-------------------------------------

{code}
+  public TezEntityDescriptor setHistoryText(String historyText) {
+    this.historyText = historyText;
+    return this;
+  }
{code}
This ends up returning a TezEntitiyDescriptor (instead of a specific 
InputDescriptor, OutputDescriptor, etc). Would need to be included in each of 
the individual classes to work correctly.
Alternately, this could be fixed for all the descriptors and the existing 
methods in this jira itself with generics.

{code}
+  public TezEntityDescriptor setUserPayload(byte[] userPayload, String 
historyText) {
+    this.userPayload = DagTypeConverters.convertToTezUserPayload(userPayload);
+    this.historyText = historyText;
+    return this;
+  }
{code}
Do we want to expose this method ? Instead, should we limit the number of 
methods and just have individual methods to set the user payload 
(setUserPayload) and set history text (setHistoryText)

Compression for history_text by default, when sending over the wire ?

A simple test to verify history text serialization would be useful.

Otherwise, looks good to me.

> Support display of user payloads in Tez UI
> ------------------------------------------
>
>                 Key: TEZ-1119
>                 URL: https://issues.apache.org/jira/browse/TEZ-1119
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: TEZ-1119.2.wip.patch, TEZ-1119.3.patch, 
> TEZ-1119.wip.patch
>
>
> Applications like Pig rely heavily on configurations bundled in as part of 
> the user payload for debugging. This requires each Input/Output/Processor's 
> user payload to be converted into something that easily consumable by the UI 
> layer to be displayed back to the user as meaningful data.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to