[
https://issues.apache.org/jira/browse/TEZ-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044135#comment-14044135
]
Bikas Saha commented on TEZ-1127:
---------------------------------
bq. Some imports may need cleaning up in TezClientUtils.java given
Do you see anything? There are no warnings in my eclipse.
bq.this is a major backward incompatible change. Is there a reason to change
the property name?
Just trying to remove language specific terminology from the API. See other
jira to rename some of the Java methods too. This also clarifies that these are
the command line options when launching the AM. Consistency with the same
config for tasks.
bq. to -Xmx1024m which has been removed/ignored.
I picked the default value from the MR default. I can change that back to 1024.
bq. should contain PWD. Incompatible with Windows I believe. Should generate a
platform specific default. Also, is it HADOOP_PREFIX or
The PWD is being set in the code. Thats because there we can rely on the NM
setting an explicit PWD env var that we can rely on. I am using the same value
as the once currently configured and used by us via
MRJobConfig.DEFAULT_MAPRED_ADMIN_USER_ENV. We can follow up in a different jira
if this should be changed.
bq. if the objective is to make users use the tez config properties
I will remove these from the next patch as they are not needed any more.
{code}- tezConf.set(TezConfiguration.TEZ_AM_JAVA_OPTS,
+ tezConf.set(TezConfiguration.TEZ_AM_LAUNCH_CMD_OPTS,
MRHelpers.getMRAMJavaOpts(tezConf));{code}
> Add TEZ_TASK_JAVA_OPTS and TEZ_ENV configs to specify values from config
> ------------------------------------------------------------------------
>
> Key: TEZ-1127
> URL: https://issues.apache.org/jira/browse/TEZ-1127
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: 0.4.0
> Reporter: Pala M Muthaia
> Assignee: Bikas Saha
> Attachments: TEZ-1127.1.patch
>
>
> There is no global setting available to specify JVM parameters for tez tasks
> (e.g: specifying native library location with java.library.path). Yarn allows
> specifying application.classpath, but not java opts. The only option right
> now is to set mapreduce.map.java.opts in the tez job config (or
> hive.tez.java.opts for Hive on Tez).
> Suggestion from Bikas, while discussing this in tez-user group, is tez should
> have "TEZ_TASK_JAVA_OPTS so that you don’t have to specify this via mapreduce
> configuration parameters"
--
This message was sent by Atlassian JIRA
(v6.2#6252)
