[
https://issues.apache.org/jira/browse/TEZ-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044980#comment-14044980
]
Bikas Saha commented on TEZ-387:
--------------------------------
Typically we pass each event sender a reference to a dispatcher. So you can
pass the event dispatcher to the client handler instead of making this method
public.
Alternatively we can create a DagAppMaster.killDAG() method and follow the
pattern used for other methods in this class.
{code} @SuppressWarnings("unchecked")
- private void sendEvent(Event<?> event) {
+ public void sendEvent(Event<?> event) {
dispatcher.getEventHandler().handle(event);
}{code}
Rest looks good.
> Move DAGClientHandler into its own class
> ----------------------------------------
>
> Key: TEZ-387
> URL: https://issues.apache.org/jira/browse/TEZ-387
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Bikas Saha
> Assignee: Jeff Zhang
> Labels: newbie
> Attachments: TEZ-387-2.patch, TEZ-387.patch, TEZ-387.patch,
> TEZ-387_1.patch, TEZ-387_3.patch, Tez-387.patch
>
>
> DAGClientHandler code lies inside the DAGAppMaster. Moving it into its own
> class will help unit testing it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
