[
https://issues.apache.org/jira/browse/TEZ-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050685#comment-14050685
]
Hitesh Shah commented on TEZ-1216:
----------------------------------
bq. TEZ_AM_STAGING_DIR_AUTO_DELETE_DEFAULT
- should be true by default
bq. + private boolean isUnregistered = false;
- is there a need for having 2 vars to indicate the same underlying
behaviour? i.e. last AM attempt. There is also another flag in
taskSchedulerEventHandler.
bq. StagingDirCleaningService
- what happens if serviceInit() and/or serviceStart() fails for some other
service? Is this service always guaranteed to be setup and its stop function
invoked always?
{code}
+ if (tezSystemStagingDir == null) {
+ LOG.warn("Job Staging directory is null");
+ return;
+ }
{code}
- why would this ever be null?
bq. fs.delete(tezSystemStagingDir, true);
- is there a reason for needing the service object? why not just setup
deleteOnExit() in the AM's constructor and/or the shutdown hook?
> Clean up the staging directory when the application completes
> -------------------------------------------------------------
>
> Key: TEZ-1216
> URL: https://issues.apache.org/jira/browse/TEZ-1216
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
> Attachments: TEZ-1216.1.patch, TEZ-1216.2.patch
>
>
> This JIRA is a part of TEZ-693. It includes the removal of stage directory
> when application's last attempt is done. In addition, it will check a config
> to determine whether to auto clean it or not.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
