[
https://issues.apache.org/jira/browse/TEZ-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054006#comment-14054006
]
Siddharth Seth commented on TEZ-1080:
-------------------------------------
bq. createDefaultBroadcastEdgeProperty(). Instead if getdefaultedgeproperty()
took an edge type argument that would also work, specially if this can be used
with custom edges.
I didn't put in a parameterized method since that would end up duplicating a
lot of the Edge configuration - custom edge manager etc. I'll see how
complicated this gets and then figure out whether one can be added.
bq. Has some leftover javadoc probably from refactoring that you can remove
before checkin. Curiosity question - what does KKK standfor?
Will clean this up. KKK is just a random search term which shouldn't exist in
the final patch - there's too many TODOs splattered in the code already.
In terms of setFromConfiguration - ideally we do not want to support this in
the future. It does filter out unused parameters, so at least the configuration
will not be super huge. This may be replaced by simple Helpers which convert a
configuration over to a map for the relevant Input/Output in the future.
> Configuration for non MR based Inputs/Outputs
> ---------------------------------------------
>
> Key: TEZ-1080
> URL: https://issues.apache.org/jira/browse/TEZ-1080
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-1080.4.txt, TEZ-1080.5.txt, TEZ-1080.wip.1.txt,
> TEZ-1080.wip.2.txt, TEZ-1080.wip.3.txt
>
>
> De-link configuration from MRHelpers (except for the YARNRunner case), and
> allow for these to be configured easily - exposing necessary setters /
> getters without having to rely on config keys.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
