[
https://issues.apache.org/jira/browse/TEZ-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bikas Saha updated TEZ-1131:
----------------------------
Attachment: TEZ-1131.3.addendum.patch
Addendum patch.
Forgot to make the same simplification for
EdgeManager.routeInputErrorEventToSource() that was made for
EdgeManager.routeDataMovementEventToDestination().
The physical index is passed directly in the parameter so that users dont have
to know that they need to get that via event.getIndex(). If change looks good
then I can rename event.getIndex() to event.getInputIndex before committing.
> Simplify EdgeManager APIs
> -------------------------
>
> Key: TEZ-1131
> URL: https://issues.apache.org/jira/browse/TEZ-1131
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Fix For: 0.5.0
>
> Attachments: TEZ-1131.1.patch, TEZ-1131.2.patch,
> TEZ-1131.3.addendum.patch
>
>
> 2 pieces of feedback from [~daijy]
> 1) Its not clear the event.sourceIndex needs to be accessed. Solution - Make
> it part of the method parameters
> 2) the Map<InputIndex, List<TaskIndex>> is convoluted. Solution - Replace
> with Map<TaskIndex, InputIndex>. Amazing why we did not do this in the first
> place.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
