[ 
https://issues.apache.org/jira/browse/TEZ-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062804#comment-14062804
 ] 

Siddharth Seth commented on TEZ-1285:
-------------------------------------

[~jeagles] - this looks good. Minor stuff.
- javadoc is incorrect (wrong variable referenced). Some comments on the method 
would be useful.
- The test is missing the Apache header.

> Add Utility for Modifying Environment Variables
> -----------------------------------------------
>
>                 Key: TEZ-1285
>                 URL: https://issues.apache.org/jira/browse/TEZ-1285
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: TEZ-1285.patch
>
>
> As part of TEZ-1206, a change was proposed to modify environment variables 
> with the jvm. There is a well known hack to get this to work, and this jira's 
> purpose is to implement this hack.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to