[ 
https://issues.apache.org/jira/browse/TEZ-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063881#comment-14063881
 ] 

Siddharth Seth commented on TEZ-1089:
-------------------------------------

Looks good, but is still missing the initial unit test. Could you please upload 
another patch including the unit test (TestCompositeDataMovementEvent)

> CompositeDataMovementEvent srcIndexEnd is not an index
> ------------------------------------------------------
>
>                 Key: TEZ-1089
>                 URL: https://issues.apache.org/jira/browse/TEZ-1089
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Siddharth Seth
>            Assignee: Chen He
>              Labels: newbie
>         Attachments: TEZ-1089-v2.patch, TEZ-1089.patch, TEZ-1089.patch
>
>
> CompositeDataMovemntEvent accepts indices for start / end. End happens to be 
> a count instead of an index - which can get confusing, especially given the 
> name (srcIndexEnd).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to