[
https://issues.apache.org/jira/browse/TEZ-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065994#comment-14065994
]
Bikas Saha commented on TEZ-1194:
---------------------------------
So TezUserPayload will become official API for payload instead of byte[]. And
TezUserPayload will have version and ByteBuffer instead of byte[]. So
constructor will look like TezUserPayload(int version, ByteBuffer payload).
Initial version of the patch could have TezUserPayload(int version, byte[]
payload). This would isolate the changes to just introducing TezUserPayload in
the API.
Then we can follow up with another patch that changes byte[] to ByteBuffer.
We can commit both patches back to back or a combined patch. Does that make
sense?
> Make TezUserPayload user facing for payload specification and change to
> ByteBuffer
> ----------------------------------------------------------------------------------
>
> Key: TEZ-1194
> URL: https://issues.apache.org/jira/browse/TEZ-1194
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
>
> Now that we have TezUserPayload being used internally to represent user
> payload it may be useful to make it user facing on the API for specifying
> payloads. Advantages
> 1) Clear code for the user instead of having untyped byte[] everywhere
> 2) Lets us internally evolve the representation of user payload and make it
> more efficient without having to break APIs. We can start with
> TezUserPayload(byte[]) and then move on to TezUserPayload(ByteBuffer) and so
> on while maintaining backwards compatibility without needing to add new
> methods. Old code can be translated within TezUserPayload while user migrates
> the code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
