[
https://issues.apache.org/jira/browse/TREQ-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Le Bas updated TREQ-10:
-------------------------------
Priority: Minor (was: Major)
The following patch solves it (AttributeExtractor.getKeys should never return
null)
---
a/tiles-request/tiles-request-servlet/src/main/java/org/apache/tiles/request/servlet/extractor/SessionScopeExtractor.java
+++
b/tiles-request/tiles-request-servlet/src/main/java/org/apache/tiles/request/servlet/extractor/SessionScopeExtractor.java
@@ -21,6 +21,7 @@
package org.apache.tiles.request.servlet.extractor;
import java.util.Enumeration;
+import java.util.Collections;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpSession;
@@ -68,7 +69,7 @@ public class SessionScopeExtractor implements
AttributeExtractor {
if (session != null) {
return session.getAttributeNames();
}
- return null;
+ return Collections.enumeration(Collections.EMPTY_SET);
}
@Override
> NPE while reading the session scope when no session has been created
> --------------------------------------------------------------------
>
> Key: TREQ-10
> URL: https://issues.apache.org/jira/browse/TREQ-10
> Project: Tiles Request
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Nicolas Le Bas
> Priority: Minor
>
> If no HttpSession has been created, the following code leads to an exception:
> Map<String, Object> scopes = new HashMap<String, Object>();
> Map<String, Object> data = request.getContext("session");
> scopes.putAll(data);
> java.lang.NullPointerException
>
> org.apache.tiles.request.util.RequestUtil.enumerationSize(RequestUtil.java:64)
>
> org.apache.tiles.request.collection.ReadOnlyEnumerationMap.size(ReadOnlyEnumerationMap.java:128)
> java.util.HashMap.putAll(HashMap.java:498)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
