[ 
https://issues.apache.org/jira/browse/TILES-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295780#comment-13295780
 ] 

Nicolas Le Bas commented on TILES-541:
--------------------------------------

Thanks for this detailed description of your solution. But I still don't 
clearly understand the problem it solves.

My guess:
- if you use spring's VelocityViewResolver, you can access the velocity toolbox 
but not Tiles' taglib.
- if you use spring's TilesViewResolver, you can access Tiles' taglib but not 
the velocity toolbox.

About your solution:
I'm not sure about forwarding the velocity context this way, I don't want to 
expose the "local" variables (#set) to the included pages. It seems dangerous, 
for instance an included page might change the value of the caller's variable. 
At the very least, you should wrap the caller's context in a new velocity 
Context.
                
> VelocityAttributeRenderer does not pass context attributes
> ----------------------------------------------------------
>
>                 Key: TILES-541
>                 URL: https://issues.apache.org/jira/browse/TILES-541
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-velocity
>    Affects Versions: 2.2.2
>            Reporter: Konrad Garus
>            Assignee: Nicolas Le Bas
>
> VelocityTilesRequestContextFactory creates VelocityTilesRequestContext which 
> still holds the velocity Context passed from outside.
> However, VelocityAttributeRenderer ignores this VelocityTilesRequestContext 
> completely and creates a new context with velocityView.createContext(request, 
> response).
> As a result the context map that is passed to Tiles from outside is not 
> passed along to Velocity. Among other things, it is causing issues with 
> integration of Spring, Tiles and Velocity.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to