[
https://issues.apache.org/jira/browse/TREQ-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421416#comment-13421416
]
Nicolas Le Bas commented on TREQ-12:
------------------------------------
Thanks for taking the time to review and test it. I missed a couple of things
indeed since I'm not using JSP currently, and you did a great job of solving
that!
I'll need to test your changes more deeply, but a few ideas on the spot:
- separate packages are fine, but if we move the code to .tiles3.request, what
would be left in .tiles3? Only TilesConfigurer?
- you know I'm uncomfortable with DispatchRequest and the forward/include
algorithm beneath it. As much as possible, I'd like to keep it internal here at
Apache so that we have a chance to improve on it eventually.
As an alternative, I would suggest to have DispatchRenderer "unwrap" its
request until it can find something dispatchable. I've been testing
[this|https://github.com/nlebas/tiles-request/blob/freemarker/tiles-request-api/src/main/java/org/apache/tiles/request/render/DispatchRenderer.java]
for some time (I'm using it for TREQ-14 non-servlet freemarker support and
possibly TREQ-13, too). It would fit the bill, I think.
- startContext/endContext: they're needed for TILES-544, i.e. for including
DispatchServlet-based stuff. But with a request-based integration, they should
be called by the Renderer (perhaps DefinitionRenderer, or a new one?), not by
RendererView. Testing would be required, but I think this integration would
allow us to take charge of TILES-544 here at Apache. IMHO, the fewer
implementation details we expose, the better.
> Spring integration
> ------------------
>
> Key: TREQ-12
> URL: https://issues.apache.org/jira/browse/TREQ-12
> Project: Tiles Request
> Issue Type: Improvement
> Reporter: Nicolas Le Bas
>
> Spring provides an integration with tiles-2. We need one for tiles-3, i.e.
> integration with the Request API.
> Tentative implementation here:
> https://github.com/nlebas/tiles-request/tree/tiles-spring
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
