[
https://issues.apache.org/jira/browse/TREQ-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Le Bas updated TREQ-12:
-------------------------------
Attachment: 0002-Fixes-and-optimizations.patch
I think I had previously missed something, because you solution works very well.
A few comments:
- I'm having second thoughts about not having a pure-request implementation.
Indeed very little change is needed to implement one: just a new class,
TilesViewResolver, and moving 3 lines of actual code to it. Then we can make
Tiles an optional dependency.
- Since you had the good idea to simplify SpringApplicationContext, it is now
identical to WildcardServletApplicationContext. Let's remove the new one and
encourage people to use the existing one.
- I've found a couple of bugs with TilesConfigurer, and the unit test was
missing.
I'm attaching a patch with these improvements and bug fixes, if you'd like to
review it.
> Spring integration
> ------------------
>
> Key: TREQ-12
> URL: https://issues.apache.org/jira/browse/TREQ-12
> Project: Tiles Request
> Issue Type: Improvement
> Reporter: Nicolas Le Bas
> Attachments: 0002-Fixes-and-optimizations.patch
>
>
> Spring provides an integration with tiles-2. We need one for tiles-3, i.e.
> integration with the Request API.
> Tentative implementation here:
> https://github.com/nlebas/tiles-request/tree/tiles-spring
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
