rob05c commented on a change in pull request #3177: Added warning SQL query for
duplicated origins
URL: https://github.com/apache/trafficcontrol/pull/3177#discussion_r245385316
##########
File path: traffic_ops/app/db/admin.pl
##########
@@ -64,7 +64,7 @@
. "dropdb - Execute db 'dropdb' on the database for the current
environment.\n"
Review comment:
> having the admin.pl script shell out all of its individual commands to the
binary
+1
>We could probably even just convert it into a bash script still named
admin.pl
-1. Perl is required by the Linux Standard Base (LSB), so there's not really
any downside of a basic Perl script that doesn't require any dependencies or
external modules (i.e. the absurd install time of TO/CPAN).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
