zrhoffman commented on a change in pull request #4356: Update generic API 
Create to allow arrays in POST if set on object
URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r373712618
 
 

 ##########
 File path: 
traffic_ops/traffic_ops_golang/profileparameter/profile_parameters.go
 ##########
 @@ -44,8 +44,9 @@ type TOProfileParameter struct {
        tc.ProfileParameterNullable
 }
 
-func (v *TOProfileParameter) NewReadObj() interface{} { return 
&tc.ProfileParametersNullable{} }
-func (v *TOProfileParameter) SelectQuery() string     { return selectQuery() }
+func (v *TOProfileParameter) AllowMultipleCreates() bool { return true }
 
 Review comment:
   `TOProfileParameter.AllowMultipleCreates()` has the same name as the 
`v1.AllowMultipleCreates` interface. Should one of these names change?
   
   Also, please comment this function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to