shamrickus commented on code in PR #7364: URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1124683940
########## experimental/traffic-portal/src/app/core/cache-groups/coordinates/detail/coordinate-detail.component.html: ########## @@ -0,0 +1,44 @@ +<!-- +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> + +<mat-card> + <tp-loading *ngIf="!coordinate"></tp-loading> + <form ngNativeValidate (ngSubmit)="submit($event)" *ngIf="coordinate"> + <mat-card-content> + <mat-form-field> + <mat-label>Name</mat-label> + <input matInput type="text" name="name" required [(ngModel)]="coordinate.name" /> + </mat-form-field> + <mat-form-field> + <mat-label>Latitude</mat-label> + <input type="number" matInput min="-90" max="90" step="0.0000001" name="latitude" [(ngModel)]="coordinate.latitude" required/> Review Comment: Same ########## experimental/traffic-portal/src/app/core/cache-groups/cache-group-details/cache-group-details.component.html: ########## @@ -56,11 +56,11 @@ <div class="pair"> <mat-form-field> <mat-label>Latitude</mat-label> - <input type="number" matInput min="-90" max="90" step="0.001" name="latitude" [(ngModel)]="cacheGroup.latitude" required/> + <input type="number" matInput min="-90" max="90" step="0.0000001" name="latitude" [(ngModel)]="cacheGroup.latitude" required/> </mat-form-field> <mat-form-field> <mat-label>Longitude</mat-label> - <input type="number" matInput min="-180" max="180" step="0.001" name="longitude" [(ngModel)]="cacheGroup.longitude" required/> + <input type="number" matInput min="-180" max="180" step="0.0000001" name="longitude" [(ngModel)]="cacheGroup.longitude" required/> Review Comment: Same as above ########## experimental/traffic-portal/src/app/core/cache-groups/cache-group-details/cache-group-details.component.html: ########## @@ -56,11 +56,11 @@ <div class="pair"> <mat-form-field> <mat-label>Latitude</mat-label> - <input type="number" matInput min="-90" max="90" step="0.001" name="latitude" [(ngModel)]="cacheGroup.latitude" required/> + <input type="number" matInput min="-90" max="90" step="0.0000001" name="latitude" [(ngModel)]="cacheGroup.latitude" required/> Review Comment: I think the step should have much higher of a step. According to [this](https://gis.stackexchange.com/questions/8650/measuring-accuracy-of-latitude-and-longitude/8674#8674) (You can just skip to the list at the bottom of the answer), the first decimal seems like a much better step. TPv1 uses integer steps but I think that's not enough precision. ########## experimental/traffic-portal/src/app/core/cache-groups/coordinates/detail/coordinate-detail.component.html: ########## @@ -0,0 +1,44 @@ +<!-- +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> + +<mat-card> + <tp-loading *ngIf="!coordinate"></tp-loading> + <form ngNativeValidate (ngSubmit)="submit($event)" *ngIf="coordinate"> + <mat-card-content> + <mat-form-field> + <mat-label>Name</mat-label> + <input matInput type="text" name="name" required [(ngModel)]="coordinate.name" /> + </mat-form-field> + <mat-form-field> + <mat-label>Latitude</mat-label> + <input type="number" matInput min="-90" max="90" step="0.0000001" name="latitude" [(ngModel)]="coordinate.latitude" required/> + </mat-form-field> + <mat-form-field> + <mat-label>Longitude</mat-label> + <input type="number" matInput min="-180" max="180" step="0.0000001" name="longitude" [(ngModel)]="coordinate.longitude" required/> Review Comment: Same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
