ocket8888 commented on code in PR #7395:
URL: https://github.com/apache/trafficcontrol/pull/7395#discussion_r1139167365
##########
lib/go-tc/users.go:
##########
@@ -127,9 +127,9 @@ type UserToken struct {
Token string `json:"t"`
}
-// commonUserFields is unexported, but its contents are still visible when it
is embedded
+// CommonUserFields is unexported, but its contents are still visible when it
is embedded
Review Comment:
but any tests for the `commonUserFields` structure should be in the same
package, no? The TO tests should only need to deal with actual user objects, I
would think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
