zrhoffman commented on PR #7521: URL: https://github.com/apache/trafficcontrol/pull/7521#issuecomment-1551698848
> > You can still add tests for testing the roles body, that will just involve adding and checking separate GET request after the POST. > > As mentioned in the issue the problem is with the immediate response from PUT and POST requests. Later GET requests have no problems and not changed in this PR. So how exactly separate GET requests could be used? Indeed, that approach won't help with test coverage here, and restructuring the TO client API library is an improvement outside the scope of this PR. Rather than adding TO API tests for #7521, adding [unit tests](https://github.com/apache/trafficcontrol/blob/d022dd84c951/traffic_ops/traffic_ops_golang/role/roles_test.go) would be more appropriate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
