ocket8888 commented on code in PR #7532: URL: https://github.com/apache/trafficcontrol/pull/7532#discussion_r1205784048
########## experimental/traffic-portal/src/app/api/export-attachment.service.ts: ########## @@ -0,0 +1,50 @@ +/* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +import { HttpClient } from "@angular/common/http"; +import { Injectable } from "@angular/core"; +import { ProfileExport, ResponseProfile } from "trafficops-types"; Review Comment: If you use `import type` instead of `import`, the compiler knows that the import statement can be thrown away - in general, that's not true because importing modules can have side-effects that you might count on, so even if all you import are types if you don't use `import type` the compiler can't tell if the import should actually be done at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
