shamrickus opened a new pull request, #7582:
URL: https://github.com/apache/trafficcontrol/pull/7582

   <!--
   Thank you for contributing! Please be sure to read our contribution 
guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
   If this closes or relates to an existing issue, please reference it using 
one of the following:
   
   Closes: #ISSUE
   Related: #ISSUE
   
   If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
   the Apache Traffic Control Security Team at 
secur...@trafficcontrol.apache.org and follow the
   guidelines at https://apache.org/security regarding vulnerability disclosure.
   -->
   
   This PR does many things:
   * Styles across forms/tables are consolidated to remove duplicates and 
ensure a consistent experience.
   * Removes FontAwesome in favor of Material Icons.
   * Enables SSR [Hydration](https://angular.io/guide/hydration)
   * Adds animations to the sidebar as well as adding a button/change collapse.
   * Adds a custom webpack configuration to compress large files using `gzip` 
and `brotli`.
   * Changes to the server to provide the compressed files if available and 
supported.
   * Added linter rule to disallow mixed spaces-tabs
   <!-- **^ Add meaningful description above** --><hr/>
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by 
this PR.
   Feel free to add the name of a tool or script that is affected but not on 
the list.
   -->
   - Traffic Portal v2
   
   ## What is the best way to verify this PR?
   Ensure the build/lint/tests pass. Confirm FontAwesome is no longer 
downloaded. Confirm sidebar works and animations are appropriate. Verify that 
js/css/svg/ttf files are compressed/served compressed if accepted. Navigate 
through the app and ensure the tables/details all look the same at various 
resolutions. If detail pages feature multiple fields per column then the card 
should be responsive based on screen width.
   <!-- Please include here ALL the steps necessary to test your PR.
   If your PR has tests (and most should), provide the steps needed to run the 
tests.
   If not, please provide step-by-step instructions to test the PR manually and 
explain why your PR does not need tests. -->
   <!-- Delete this section if the PR is not a bugfix, or if the bug is only in 
the master branch.
   Examples:
   - 5.1.2
   - 5.1.3 (RC1)
    -->
   
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why 
this PR does not need tests. -->
   - [ ] This PR has documentation <!-- If not, please delete this text and 
explain why this PR does not need documentation. -->
   - [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC 
release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security guidelines](https://apache.org/security) 
for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to