ocket8888 commented on code in PR #7584:
URL: https://github.com/apache/trafficcontrol/pull/7584#discussion_r1239039915
##########
docs/Makefile:
##########
@@ -18,11 +18,21 @@
# under the License.
#
+ifeq ($(OS),Windows_NT)
+ T3C_DIR_SEP := \\
+ RM := del /s /q
+ PY := python
+else
+ T3C_DIR_SEP := /
+ RM := rm -rf
Review Comment:
The build directory is its own file, `make` wasn't really meant to make
directories and that shows here.
Ideally it'd be that easy, but you can always just do it in two steps
```makefile
clean:
-$(RM) $(BUILDDIR)/* $(T3C_RST_OUT)
-rmdir $(BUILDDIR)
```
Since `rmdir` exists on all OSes of which I'm aware, that should always work
provided the directory is empty. Keeps you from having to define some variable
based on OS - although it looks like you gotta do that anyway with Python for
some reason?
Honestly, though, you could also just get rid of the `clean` target. It's
not really necessary.
You can do it however you want, but if you want to define a new variable for
it, definitely stick with e.g. `REM` rather than re-defining a built-in like
`RM`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
