ocket8888 commented on PR #7586: URL: https://github.com/apache/trafficcontrol/pull/7586#issuecomment-1618807362
> > > are you saying we should NOT run seed on upgrade? > > > > > > yes. I think there was a reason we needed o do that, but I think that particular reason is no longer applicable. Hard to say, though, because I'm not totally sure the reason ever existed, let alone what it was. > > Regardless if the reason still applies, `admin upgrade` does still run seeds after migrations. > > You're right that updating `seeds.sql` can technically wait until migrations are squashed in the next release, but most DB squashing happens in `create_tables.sql`, so giving the DB squasher a manual step in `seeds.sql` is a little tedious and we might as well do it now so it doesn't get missed. I wasn't saying it *should* wait, I was saying it *must*, otherwise we're escalating permissions. That makes it a security-related bug that operations's permissions have been upgraded. I'll go change `admin` to not re-do seeding on upgrade so I can give the release including the change a +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
