[GitHub] [trafficcontrol] rawlinp commented on a diff in pull request #7622: Traffic Router DNS zone calculation optimizations

[via GitHub]

rawlinp commented on code in PR #7622:
URL: https://github.com/apache/trafficcontrol/pull/7622#discussion_r1258666972


##########
traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/edge/CacheRegister.java:
##########
@@ -22,6 +22,8 @@
 
 import org.apache.traffic_control.traffic_router.core.ds.DeliveryService;
 import 
org.apache.traffic_control.traffic_router.core.ds.DeliveryServiceMatcher;
+import org.apache.traffic_control.traffic_router.core.request.DNSRequest;
+import org.apache.traffic_control.traffic_router.core.request.HTTPRequest;

Review Comment:
   these imports appear to be unused now



##########
traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/config/ConfigHandler.java:
##########
@@ -469,6 +474,9 @@ private Map<String, DeliveryService> 
parseDeliveryServiceConfig(final JsonNode a
 
                        deliveryService.setDns(isDns);
                        deliveryServiceMap.put(deliveryServiceId, 
deliveryService);
+                       
fqdnToDeliveryService.put(deliveryService.getRoutingName() + "." + 
deliveryService.getDomain(), deliveryService);
+                       fqdnToDeliveryService.put("_" + "." + 
deliveryService.getDomain(), deliveryService);

Review Comment:
   nit: could be `"_."` instead of `"_" + "."`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org