zrhoffman commented on code in PR #7625:
URL: https://github.com/apache/trafficcontrol/pull/7625#discussion_r1258954523
##########
infrastructure/ansible/roles/traffic_ops/templates/cdn.conf.j2:
##########
@@ -81,7 +81,9 @@
"password": "{{ to_riak_username_password }}",
"MaxTLSVersion": "{{ to_riak_tls_max_version }}"
{% endif %}
- }
+ },
+ "whitelisted_oauth_urls": {{ to_whitelisted_oauth_urls | to_json }},
Review Comment:
Since `whitelisted_oauth_urls` is in the `traffic_ops_golang` section of
`cdn.conf`, the corresponding Ansible variable should start with `to_go_`, not
just `to_`.
##########
infrastructure/ansible/roles/traffic_ops/templates/cdn.conf.j2:
##########
@@ -81,7 +81,9 @@
"password": "{{ to_riak_username_password }}",
"MaxTLSVersion": "{{ to_riak_tls_max_version }}"
{% endif %}
- }
+ },
+ "whitelisted_oauth_urls": {{ to_whitelisted_oauth_urls | to_json }},
+ "oauth_client_secret": "{{ to_oauth_client_secret }}"
Review Comment:
`to_oauth_client_secret` is not in `roles/traffic_ops/defaults/main.yml`. It
should be added in the `to_go_` section:
https://github.com/apache/trafficcontrol/blob/71c405c8f56ccbdc848ddab962bd2c9f9a65df79/infrastructure/ansible/roles/traffic_ops/defaults/main.yml#L75-L77
##########
infrastructure/ansible/roles/traffic_ops/templates/cdn.conf.j2:
##########
@@ -81,7 +81,9 @@
"password": "{{ to_riak_username_password }}",
"MaxTLSVersion": "{{ to_riak_tls_max_version }}"
{% endif %}
- }
+ },
+ "whitelisted_oauth_urls": {{ to_whitelisted_oauth_urls | to_json }},
+ "oauth_client_secret": "{{ to_oauth_client_secret }}"
Review Comment:
Since `oauth_client_secret` is in the `traffic_ops_golang` section of
`cdn.conf`, the corresponding Ansible variable should start with `to_go_`, not
just `to_`.
##########
infrastructure/ansible/roles/traffic_ops/templates/cdn.conf.j2:
##########
@@ -81,7 +81,9 @@
"password": "{{ to_riak_username_password }}",
"MaxTLSVersion": "{{ to_riak_tls_max_version }}"
{% endif %}
- }
+ },
+ "whitelisted_oauth_urls": {{ to_whitelisted_oauth_urls | to_json }},
Review Comment:
`to_whitelisted_oauth_urls` is not in `roles/traffic_ops/defaults/main.yml`.
It should be added in the `to_go_` section:
https://github.com/apache/trafficcontrol/blob/71c405c8f56ccbdc848ddab962bd2c9f9a65df79/infrastructure/ansible/roles/traffic_ops/defaults/main.yml#L75-L77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
