zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1279957834
########## experimental/traffic-portal/src/app/api/testing/topology.service.ts: ########## @@ -0,0 +1,155 @@ +/* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +import { Injectable } from "@angular/core"; +import { + RequestTopology, + ResponseTopology, + ResponseTopologyNode +} from "trafficops-types"; + +import { TopologyService as ConcreteService, TopTreeNode } from "src/app/api"; + +/** + * TopologyService expose API functionality relating to Topologies. + */ +@Injectable() +export class TopologyService { + private readonly topologies: ResponseTopology[] = [ + { + description: "", + lastUpdated: new Date(), + name: "test", + nodes: [ + { + cachegroup: "Edge", + parents: [1], + }, + { + cachegroup: "Mid", + parents: [2], + }, + { + cachegroup: "Origin", + parents: [], + }, + ], + }, + ]; + + /** + * Gets one or all Topologies from Traffic Ops + * + * @param name The unique name of a single Topology to be returned + * @returns Either an Array of Topologies or a single Topology, depending on whether `name` was + * passed. + */ + public async getTopologies(name?: string): Promise<Array<ResponseTopology> | ResponseTopology> { + if (name !== undefined) { + const topology = this.topologies.find(t => t.name === name); + if (!topology) { + throw new Error(`no such Topology ${name}`); + } + return topology; + } + return this.topologies; + } Review Comment: I have a strong preference to not change the concrete service this late in the review cycle. Matching the call signature in a5a39eca0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
