ocket8888 commented on code in PR #7734:
URL: https://github.com/apache/trafficcontrol/pull/7734#discussion_r1304856157
##########
traffic_ops/traffic_ops_golang/profile/profiles.go:
##########
@@ -226,10 +228,10 @@ LEFT JOIN cdn c ON prof.cdn = c.id`
return query
}
-func ReadParameters(tx *sqlx.Tx, parameters map[string]string, user
*auth.CurrentUser, profile tc.ProfileNullable) ([]tc.ParameterNullable, error) {
+func ReadParameters(tx *sqlx.Tx, user *auth.CurrentUser, profileID *int)
([]tc.ParameterNullable, error) {
privLevel := user.PrivLevel
queryValues := make(map[string]interface{})
- queryValues["profile_id"] = *profile.ID
+ queryValues["profile_id"] = profileID
Review Comment:
It shouldn't ever be `nil`, that's my point. If it can't ever be `nil` then
there's no need for it to be a pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
