srijeet0406 commented on code in PR #7885:
URL: https://github.com/apache/trafficcontrol/pull/7885#discussion_r1431727021
##########
traffic_ops/traffic_ops_golang/profile/profiles.go:
##########
@@ -439,9 +439,9 @@ func Read(w http.ResponseWriter, r *http.Request) {
profileInterfaces := []interface{}{}
for _, p := range profileList {
- // Attach Parameters if the 'param' parameter is sent
- if _, ok := inf.Params["param"]; ok {
- p.Parameters, err = ReadParameters(inf.Tx, inf.User,
p.ID, inf.User.Can("PARAMETER-SECURE:READ"))
+ // Attach Parameters if the 'id' parameter is sent
+ if _, ok := inf.Params["id"]; ok {
+ p.Parameters, err = ReadParameters(inf.Tx, inf.User,
p.ID, inf.User.Can("PARAMETER:SECURE-READ"))
Review Comment:
Could you pls use the `tc.PermParameterSecureRead` constant instead? That
will avoid any future typos like this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
