[
https://issues.apache.org/jira/browse/TC-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830413#comment-15830413
]
ASF GitHub Bot commented on TC-68:
----------------------------------
GitHub user mitchell852 opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/200
[TC-68] - to support an HA TO, regex_revalidate.config can't live on the
file system
you'll have to use the "genfiles" route to fetch regex_revalidate.config.
i.e.
GET /genfiles/view/:host_name/regex_revalidate.config
therefore, you'll see a change to ORT in this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mitchell852/incubator-trafficcontrol tc-68
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/200.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #200
----
commit a47f2fd6bc7cc4cdec84d4b82d49d25abe5202fc
Author: Jeremy Mitchell <mitchell...@gmail.com>
Date: 2017-01-19T18:48:25Z
removes regex_revalidate.config from the filesystem (tc-68)
commit 2ec07a0744c19925e2f48b3e6af3c21a01292f14
Author: Jeremy Mitchell <mitchell...@gmail.com>
Date: 2017-01-19T18:49:35Z
fixes super brittle fixtures that broke when a parameter was removed from
integration/Parameter.pm
----
> To support an HA TO, regex_revalidate.config should not be written to the
> file system
> -------------------------------------------------------------------------------------
>
> Key: TC-68
> URL: https://issues.apache.org/jira/browse/TC-68
> Project: Traffic Control
> Issue Type: Improvement
> Components: Traffic Ops
> Reporter: Jeremy Mitchell
> Assignee: Jeremy Mitchell
> Fix For: 2.0.0
>
>
> Currently, when an "invalidate content" request is created via one of these 2
> routes:
> - POST /api/$version/user/current/jobs (thru the API)
> - POST /job/external/new (thru the UI)
> regex_revalidate.config is written to the file system at the location
> dictated by the 'snapshot_dir' parameter:
> https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/db/seeds.sql#L32
> In order to support a highly-available/redundant TO, we need to remove all
> dependencies on files written to the file system.
> My suggestion is that we remove all calls to snapshot_regex_revalidate()
> which will stop regex_revalidate.config from being written to the file system.
> https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/MojoPlugins/Job.pm#L35
> After this is done. regex_revalidate.config can be retrieved like all other
> ATS config files using the following route:
> /genfiles/view/:host_name/regex_revalidate.config
> If this change is made, ORT would also have to change
> https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/bin/traffic_ops_ort.pl#L2159
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
