Github user nir-sopher commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/322
These columns are not relevant after downgrade (until next upgrade).
What is the common practice in such cases in TC?
On Mar 6, 2017 8:25 PM, "Jeremy Mitchell" <notificati...@github.com> wrote:
> *@mitchell852* commented on this pull request.
> ------------------------------
>
> In traffic_ops/app/db/migrations/20170221000001_initial_tenancy.sql
>
<https://github.com/apache/incubator-trafficcontrol/pull/322#discussion_r104485020>
> :
>
> > +
> +-- +goose Down
> +-- SQL section 'Down' is executed when this migration is rolled back
> +
> +ALTER TABLE deliveryservice
> +DROP COLUMN tenant_id;
> +
> +ALTER TABLE cdn
> +DROP COLUMN tenant_id;
> +
> +ALTER TABLE tm_user
> +DROP COLUMN tenant_id;
> +
> +DROP TRIGGER on_update_current_timestamp ON tenant;
> +
> +DROP TABLE tenant;
>
> do you need to drop the 3 indexes you created as well? in the goose down?
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/incubator-trafficcontrol/pull/322#pullrequestreview-25325057>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AXGkYIkLacy8AbJWaRpq04DThqNm7P-Nks5rjE-fgaJpZM4MOyR9>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
