Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109291378
--- Diff: traffic_ops/app/lib/API/User.pm ---
@@ -159,6 +161,9 @@ sub update {
return $self->not_found();
}
+ #setting tenant_id to undef if tenant is not set. TODO(nirs): remove
when tenancy is no longer optional in the API
+ my $tenant_id = exists($params->{tenantId}) ? $params->{tenantId} :
undef;
--- End diff --
Indeed it will be sufficient. Still I prefer to be explicit so the code
documents itself.
Can I leave it that way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
