[ https://issues.apache.org/jira/browse/TC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952346#comment-15952346 ]
ASF GitHub Bot commented on TC-184: ----------------------------------- Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109291378 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -159,6 +161,9 @@ sub update { return $self->not_found(); } + #setting tenant_id to undef if tenant is not set. TODO(nirs): remove when tenancy is no longer optional in the API + my $tenant_id = exists($params->{tenantId}) ? $params->{tenantId} : undef; --- End diff -- Indeed it will be sufficient. Still I prefer to be explicit so the code documents itself. Can I leave it that way? > Tenant Hierarchy > ---------------- > > Key: TC-184 > URL: https://issues.apache.org/jira/browse/TC-184 > Project: Traffic Control > Issue Type: New Feature > Components: Traffic Ops > Reporter: Ryan Durfey > Labels: Access, Tenancy > > Design under discussion here: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68715910 > The requirements below are seed requirements and final design guidance should > defer to the evolving wiki page discussion referenced above. > Overview > The goal of this system is to create a hierarchical tenancy system which is > very simple to understand and administer and is highly expandable so that > large organizations with many subsidiaries have the flexibility to create > child-tenants to their liking. > General Seed Requirements > 1. Provide a structure to create a hierarchy of Tenants where each Tenant has > a single parent-Tenant and can have multiple child-Tenants > 2. Provide the ability to group multiple Delivery Services, Users, and child- > Tenants under each Tenant > 3. Provide the ability to create at least 10 child-Tenant layers within the > system > 4. Make it easy to assign a User to a single Tenant so that they inherit > their permissions to all child-Tenants and Delivery Services. > 5. Adding child-Tenants or Delivery Services anywhere in an existing tenant > hierarchy does not require re-assigning users. Users inherit pre-defined > permissions to new tenants and services added below their assigned layer in > the tenancy tree. > 6. Allow Users to be assigned multiple Tenants, each with different Roles. > While a user would inherit their access to all services and child Tenants > below them, they may need more restrictive access further up the Tenant > hierarchy or they may want different access to another branch of the tenant > tree. -- This message was sent by Atlassian JIRA (v6.3.15#6346)