[ https://issues.apache.org/jira/browse/TC-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968314#comment-15968314 ]
ASF GitHub Bot commented on TC-223: ----------------------------------- GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/469 [BACKPORT TC-223] - default regex is required on a ds before dnssec keys can be created (… …if required) (cherry picked from commit c3ad83792530159cef0daf0310c768a47e680888) # Conflicts: # traffic_ops/app/lib/API/Deliveryservice.pm You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol 2.0.x-tc-223 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/469.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #469 ---- commit e4337c05f94645e7d8eb016f1694522723721b97 Author: Jeremy Mitchell <mitchell...@gmail.com> Date: 2017-04-13T02:45:42Z default regex is required on a ds before dnssec keys can be created (if required) (cherry picked from commit c3ad83792530159cef0daf0310c768a47e680888) # Conflicts: # traffic_ops/app/lib/API/Deliveryservice.pm ---- > Creating a DS through the API results in an invalid DNSSEC keypair > ------------------------------------------------------------------ > > Key: TC-223 > URL: https://issues.apache.org/jira/browse/TC-223 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops > Affects Versions: 2.0.0, 2.1.0 > Reporter: David Neuman > Assignee: Jeremy Mitchell > > If you have DNSSEC enabled and you create a DS from the API, a DNSSEC keypair > with name = "" gets created (example below). It looks like this happens > because when you create a DS through the API you don't create the DS with a > regex. When the create method calls create_dnssec_keys that method uses the > regex to create the name field. > {quote} > "Test-DS-1491489049" : { > "zsk" : [ > { > "effectiveDate" : 1491489041, > "public" : "...", > "private" : "...", > "expirationDate" : 1494081041, > "name" : "", > "status" : "new", > "inceptionDate" : 1491489041, > "ttl" : "60" > } > ], > "ksk" : [ > { > "status" : "new", > "ttl" : "60", > "inceptionDate" : 1491489041, > "public" : "...", > "effectiveDate" : 1491489041, > "name" : "", > "private" : "...", > "expirationDate" : 1523025041 > } > ] > }, > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346)