[
https://issues.apache.org/jira/browse/TC-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983732#comment-15983732
]
ASF GitHub Bot commented on TC-251:
-----------------------------------
GitHub user dneuman64 opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/518
BACKPORT -- [TC-251] Fixed an issue where Traffic Ops was not correctly
refreshing DNSSEC keys
I had to fix fork_and_daemonize() so that it would do what we needed. We
want that method to fork off a child and return while the child does its thing
in the backgroup (without waiting for the child). This functionality was
changed in 2.0 because the previous implementation was causing issues with
processes that use waitpid(), see TC-158. The new method is similar to the pre
2.0 method except it does not set a the SIGCHILD handler to IGNORE and it
cleans up completed child processes each time it is called. This hopefully
satisfies the requirements of running asynchronously while also not leaving
zombie processes and using up all of the traffic_ops workers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dneuman64/incubator-trafficcontrol
TC-251-backport
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/518.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #518
----
commit dfea2f4afb05cb072be529736431cc1a2dff01fe
Author: David Neuman <david.neuma...@gmail.com>
Date: 2017-04-25T20:57:59Z
Updated daemonize to reap exited child processes when it is run. Also
updated it so it actually runs the forked process in the background instead of
blocking
(cherry picked from commit bc2c06aad6abbac6215e1cefd1748f654a4fb1d9)
commit 70fe56592b7bede2047552dc02dd96dee1e8a549
Author: David Neuman <david.neuma...@gmail.com>
Date: 2017-04-25T21:00:09Z
Fixed and issue where a search for DSs was using a profile ID instead of
cdn_id
(cherry picked from commit 3f6f1cc17befc970bc0bf5cff8ff5023bd48c27c)
----
> DNSSEC keys refresh doesn't work
> --------------------------------
>
> Key: TC-251
> URL: https://issues.apache.org/jira/browse/TC-251
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
> Affects Versions: 2.0.0, 2.1.0
> Reporter: David Neuman
> Assignee: David Neuman
> Fix For: 2.0.0, 2.1.0
>
>
> They DNSSEC keys route doesn't work. It never returns a reponse to the
> client, so the client times out, and it also isn't actually updating the
> expired keys. I think the client issues was introduced with changes to the
> "fork_and_daemonize()" method.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
