Github user oren-shemesh commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafficcontrol/pull/521#discussion_r113468159
  
    --- Diff: traffic_ops/app/lib/MojoPlugins/Daemonize.pm ---
    @@ -41,12 +41,6 @@ sub register {
                                # This is the first child
                                $self->inactivity_timeout(0);
                                POSIX::setsid();
    -                           open( STDIN, "< /dev/null" )
    -                                   || confess("Can't read /dev/null: $!");
    --- End diff --
    
    Why are you removing these lines ?
    They make sure that any accidental input/output activity in the child 
process will not interfere with the parent process.
    It is a standard thing to do when spawning child processes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to