Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r130238728 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -445,18 +431,27 @@ sub get_servers_by_dsid { my $orderby_snakecase = lcfirst( decamelize($orderby) ); my $helper = new Utils::Helper( { mojo => $self } ); + my $ds = $self->db->resultset('Deliveryservice')->search( { 'me.id' => $ds_id }, { prefetch => ['type'] } )->single(); + my $tenant_utils = Utils::Tenant->new($self); + my $tenants_data = $tenant_utils->create_tenants_data_from_db(); + my @ds_servers; my $forbidden; - if ( &is_privileged($self) || $self->is_delivery_service_assigned($ds_id) ) { + my $servers; + + if (defined($ds) && !$tenant_utils->is_ds_resource_accessible($tenants_data, $ds->tenant_id)) { + $forbidden = "Forbidden. Delivery service not available for user's tenant."; + return ($forbidden, $servers); + } + elsif ( &is_privileged($self) || $tenant_utils->ignore_ds_users_table() || $self->is_delivery_service_assigned($ds_id) ) { --- End diff -- Same, answer:)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---