Github user mtorluemke commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafficcontrol/pull/772#discussion_r131169393
  
    --- Diff: traffic_monitor_golang/traffic_monitor/threadsafe/polledcaches.go 
---
    @@ -103,11 +116,22 @@ func copyCaches(a map[enum.CacheName]struct{}) 
map[enum.CacheName]struct{} {
        return b
     }
     
    +func copyCachesTime(a map[enum.CacheName]time.Time) 
map[enum.CacheName]time.Time {
    +   b := map[enum.CacheName]time.Time{}
    +   for k, v := range a {
    +           b[k] = v
    +   }
    +   return b
    +}
    +
    +const PolledBytesPerSecTimeout = time.Second * 60
    --- End diff --
    
    Good concept -- I would pick something closer to 10 seconds, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to