WCCP doesn't build on trunk.
----------------------------

                 Key: TS-664
                 URL: https://issues.apache.org/jira/browse/TS-664
             Project: Traffic Server
          Issue Type: Bug
          Components: Build
    Affects Versions: 2.1.6
            Reporter: Alan M. Carroll
            Assignee: Alan M. Carroll
            Priority: Minor
             Fix For: 2.1.6


If the --enable-wccp option is used for configuration, the build fails.

This is a bit ugly because the WCCP code is in proxy but used by 
traffic_manager. Additionally, it is part of the LocalManager object which 
creates header file dependencies in most of the mgmt sub projects.

The work plan is

1) Move WCCP to lib. This is a more appropriate location for it and removes the 
build circularity.
2) Change the include style to use top_srcdir/lib generically instead of 
subdirectories inside lib.
3) Change the WCCP and TsConfig includes to use subdirectories (e.g., 
wccp/Wccp.h).
4) Do some clean up on LocalManager dependencies.

(1) wasn't done initially because the lib directory didn't exist. Now that it 
does, WCCP should reside there. (2) and (3) in combination means that projects 
that don't directly depend on WCCP don't need to have their makefiles modified 
to support it, only to have lib as a base include directory.

In addition, in mgmt, Main.h includes LocalManager.h and LocalManager.h 
includes Main.h. Because of include protection this doesn't recursively explode 
but it seems ... suboptimal. I will remove the include of LocalManager.h from 
Main.h and adjust mgmt projects as needed to include LocalManager.h if they 
actually need it (some do, such as cluster).

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to