[
https://issues.apache.org/jira/browse/TS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026758#comment-13026758
]
John Plevyak commented on TS-752:
---------------------------------
I reviewed this and it looks good to me. I'd move vol_relative_length
into the header (for symetry).
The fix for partial objects I think is nice as well.
I don't see the crash fix in svn5.diff, so I am assuming that the two are
independent.
Since this patch is all about scan it should be safe.
William, how much testing have you given this? If you are comfortable, I'll
give it a smoke test and commit.
> cache scan issues
> -----------------
>
> Key: TS-752
> URL: https://issues.apache.org/jira/browse/TS-752
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Environment: Any
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Fix For: 2.1.8
>
> Attachments: svn4.diff, svn4.diff, svn5.diff
>
>
> Using the CacheScan plugin APIs I found a few issues.
> Issue 1 is that if you cancel a scan really quickly you can get a NULL
> dereference, the fix for this is easy.
> Issue 2 is that the cache scan code can skip over entries if the initial
> header overlaps a buffer boundary.
> Issue 3 is that the cache scan code is crazy slow if your cache is not full,
> it still scans everything.
> I will attach a patch for Issues 2 & 3 mixed together...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
