[ 
https://issues.apache.org/jira/browse/TS-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036424#comment-13036424
 ] 

John Plevyak commented on TS-621:
---------------------------------

Obviously the patch needs to be fixed up a bit.  The Cluster used the
CacheDataType
as a message type, so I hacked in:

 enum CacheDataType
 {
   CACHE_DATA_SIZE = VCONNECTION_CACHE_DATA_BASE,
-  CACHE_DATA_HTTP_INFO,
+  CACHE_DATA_HTTP_INFO_LEAVE_BODY,
+  CACHE_DATA_HTTP_INFO_REPLACE_BODY,
   CACHE_DATA_KEY,
   CACHE_DATA_RAM_CACHE_HIT_FLAG
 };

Which doesn't really make sense.  The leave/replace bit should be encoded
somewhere else in the message.

The changes to CacheWrite are very tricky and I have little faith in them.

We could land it, but we would needs some serious testing...





> writing 0 bytes to the HTTP cache means only update the header... need a new 
> API: update_header_only() to allow 0 byte files to be cached
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TS-621
>                 URL: https://issues.apache.org/jira/browse/TS-621
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Cache
>    Affects Versions: 2.1.5
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.9
>
>         Attachments: TS-621_cluster_zero_size_objects.patch, 
> ts-621-jp-1.patch, ts-621-jp-2.patch, ts-621-jp-3.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to