[ 
https://issues.apache.org/jira/browse/TS-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064740#comment-13064740
 ] 

Leif Hedstrom commented on TS-875:
----------------------------------

That's not confusing at all :) Why are the APIs using TSHttpTxn as the input 
parameter in the first place?. Wish we had seen this before 3.0, and we could 
have changed that. Now your "fix" is correct, but I'm wondering if we should 
deprecate these APIs, and replace them with something that takes an appropriate 
parameter?

P.s You should email private@ :-).

> TSFetchRestpGet(), TSFetchPageResptGet() and TSFetchUrl() have incorrect 
> asserts
> --------------------------------------------------------------------------------
>
>                 Key: TS-875
>                 URL: https://issues.apache.org/jira/browse/TS-875
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>    Affects Versions: 3.0.0
>            Reporter: Manjesh Nilange
>         Attachments: inkapi.patch
>
>
> The asserts cause TS to crash when these API functions are used. The asserts 
> are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM 
> pointer as apparent in the code that follows.
> And TSFetchUrl allows continuations to make requests with no callbacks and 
> for such code paths, the continuation check should not be done.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to