[
https://issues.apache.org/jira/browse/TS-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125568#comment-13125568
]
Conan Wang commented on TS-948:
-------------------------------
My test:
1. duplicate remap rule and adding non-exist remap plugin now will not crash
running ATS. I can see "WARNING: failed to reload remap.config, not replacing!"
in traffic.out.
2. though bad remap.config is not reloaded, seem "TSRemapDeleteInstance"
(TSfree ihandle) of my remap plugin is called according to my debug log.
However, my remap plugin work well like before, that is, I can still retrieve
the stored variable in ihandle. I don't know whether there is potential problem.
3. return TS_ERROR in "TSRemapNewInstance" still crash.
{code}
Server {0x1079f6000} ERROR: Failed to create new instance for plugin
/Users/conan/box/ts-trunk/libexec/trafficserver/add_header.so (non-zero
retval)... bailing out
FATAL: UnixUDPNet.cc:295: failed assert `event != NULL`
/Users/conan/box/ts-trunk/bin/traffic_server - STACK TRACE:
0 libtsutil.3.dylib 0x0000000102fb05ab ink_fatal_va + 283
1 libtsutil.3.dylib 0x0000000102fb08b4 ink_fatal + 356
2 libtsutil.3.dylib 0x0000000102fadcff _ink_assert + 271
3 traffic_server 0x0000000102684f45
_ZN19UDPReadContinuationD1Ev + 85
4 traffic_server 0x00000001026850c6
_ZN14ClassAllocatorI19UDPReadContinuationE4$_44D1Ev + 24
5 traffic_server 0x000000010268f59d
_ZN14ClassAllocatorI19UDPReadContinuationED1Ev + 37
6 traffic_server 0x00000001026850eb __tcf_3 + 27
7 libsystem_c.dylib 0x00007fff872217c8 __cxa_finalize + 274
8 libsystem_c.dylib 0x00007fff87221652 exit + 18
9 traffic_server 0x00000001024aca9c
_ZN10UrlRewrite17load_remap_pluginEPPciP11url_mappingS0_iiPi + 8284
10 traffic_server 0x00000001024b5473
_ZN10UrlRewrite10BuildTableEv + 12757
11 traffic_server 0x00000001024b8dc5
_ZN10UrlRewriteC1EPKc + 2165
12 traffic_server 0x00000001023b450e
_Z16reloadUrlRewritev + 350
13 traffic_server 0x00000001023b5296
_ZN21UR_UpdateContinuation19file_update_handlerEiPv + 24
14 traffic_server 0x00000001023d7434
_ZN12Continuation11handleEventEiPv + 148
15 traffic_server 0x00000001026a787a
_ZN7EThread13process_eventEP5Eventi + 418
16 traffic_server 0x00000001026a6c85
_ZN7EThread7executeEv + 191
17 traffic_server 0x00000001026a6174
_ZL21spawn_thread_internalPv + 132
18 libsystem_c.dylib 0x00007fff8722e8bf _pthread_start + 335
19 libsystem_c.dylib 0x00007fff87231b75 thread_start + 13
{code}
> do not reload bad remap.config
> ------------------------------
>
> Key: TS-948
> URL: https://issues.apache.org/jira/browse/TS-948
> Project: Traffic Server
> Issue Type: Improvement
> Components: Configuration, Management
> Affects Versions: 3.1.0, 3.0.1
> Reporter: Conan Wang
> Assignee: Leif Hedstrom
> Priority: Critical
> Fix For: 3.1.1
>
>
> traffic_server will exit if exists bad rules in remap.config, whenever
> startup or reload ( traffic_line -x ).
> If remap.config is not edited correctly, the server/cluster will crash when
> reloading.
> It's better to pre-check the remap table and not switch to the new table if
> remap.config is not enough correct.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
