[ 
https://issues.apache.org/jira/browse/TS-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187326#comment-13187326
 ] 

Nick Kew commented on TS-998:
-----------------------------

The URL used for logging (at least the error log) is broken in exactly the same 
way.  That is to say, for example,

GET / HTTP/1.0
Host: something.unrecognised

logs an error with the URL as "http:///"; , with the usual three slashes

I'm confused by the number of places we seem to store this URL that always 
reconstructs incorrectly.  The correct buffer appears in many places, and my 
patch just attempts to store a reference to it at a point in processing when 
(AFAICT) it's known to be valid.  I'm not sure what you mean by stringify: it 
sounds like a lot of work (as does copying it).
                
> Broken ClientReq in TSAPI
> -------------------------
>
>                 Key: TS-998
>                 URL: https://issues.apache.org/jira/browse/TS-998
>             Project: Traffic Server
>          Issue Type: Bug
>    Affects Versions: 3.0.1
>         Environment: any
>            Reporter: Nick Kew
>            Assignee: Nick Kew
>             Fix For: 3.1.2
>
>
> Extracting a Request using TSHttpTxnClientReqGet API yields a bogus Request 
> line.
> Expected behaviour: In a PRE_REMAP hook it should return the client request 
> line and headers, ideally verbatim.
> Observed behaviour: "http://"; is prepended to the request URL:
>   GET /path/ HTTP/1.1
> becomes
>   GET http:///path/ HTTP/1.1
> (yes, that's three slashes)
> Pseudo-code to reproduce from a PRE_REMAP hook:
>   TSHttpTxnClientReqGet(txnp, &buf, &hdr);
>   TSHttpHdrPrint(buf, hdr, iobuf);
>   reader = TSIOBufferReaderAlloc(iobuf);
>   block = TSIOBufferReaderStart(reader);
>   len = TSIOBufferBlockReadAvail(block, reader);
>   data = TSIOBufferBlockReadStart(block, reader, &len);
> Now examine the contents of data.
> Assigned to AMC as suggested yesterday on-list.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to