[
https://issues.apache.org/jira/browse/TS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200789#comment-13200789
]
Leif Hedstrom commented on TS-1102:
-----------------------------------
I still get rejected hunks:
{code}
loki (08:12) 363/0 $ patch -p0 < remove_prefix_arg_v2.patch
patching file lib/records/RecUtils.cc
patching file lib/ts/Diags.cc
patching file lib/ts/Diags.h
Hunk #4 FAILED at 242.
Hunk #5 FAILED at 358.
Hunk #6 succeeded at 437 (offset 8 lines).
2 out of 6 hunks FAILED -- saving rejects to file lib/ts/Diags.h.rej
patching file proxy/Error.cc
patching file proxy/InkAPI.cc
patching file proxy/DiagsConfig.cc
patching file mgmt/api/CoreAPI.cc
patching file mgmt/utils/MgmtUtils.cc
{code}
I'll look at it later tonight. Are you sure you're pulling the latest trunk
(from git) ?
> Cleanup obsolete debugging code
> -------------------------------
>
> Key: TS-1102
> URL: https://issues.apache.org/jira/browse/TS-1102
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, Logging, Performance
> Affects Versions: 3.0.2
> Environment: Any
> Reporter: Uri Shachar
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.3
>
> Attachments: diags_cleanup.patch, remove_prefix_arg.patch,
> remove_prefix_arg_v2.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc >= 4.1
> for all compilation environments, and it includes variadic argument macro
> support with ##_VA_ARGS_ that deletes the final comma if no arguments are
> provided.
> Removing the added layer should also improve performance when high volume
> debugging is turned on.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
