On Thu, Jan 31, 2013 at 2:17 PM, James Peach (JIRA) <j...@apache.org> wrote:
> > [ > https://issues.apache.org/jira/browse/TS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567397#comment-13567397] > > James Peach commented on TS-1006: > --------------------------------- > > Some thoughts: > - we should start work on merging this, because I don't think it will > get sufficient review outside of trunk > - unless there is a performance cost, it should always be compiled in > but default to disabled at runtime > Agree. > - when merging, break it down into smaller, uncontroversial pieces; > for example add the configuration options first, then some infrastructure, > then more functional pieces; try to avoid the unnecessary whitespace and > general fix changes > Ok, I can split them into more pieces. > - do we really need another linked list? > When I developed this patchset, I was not so familiar with TS library. Now, I have found that there is a List.h file containing templated single-link/double-link list library. I'll try to use templated-list in this patchset, although I prefer C-Style link list:D. > - it would be great to have some unit tests > Agree, but I'm busy with other things now. Unit tests is not so urgent for us, maybe I'll write some tests in the future. I'll give a new version later with your advise. Thank you! > > :) > > -- Yunkai Zhang Work at Taobao
