[ 
https://issues.apache.org/jira/browse/TS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631112#comment-13631112
 ] 

John Plevyak commented on TS-1405:
----------------------------------

A third drop in performance on any test is a red flag.  There is definitely 
something wrong.  There are two things going on in this patch.  1) it replaces 
the power of 2 buckets with a time wheel and 2) it introduces an atomic list as 
a mechanism for freeing up events quickly.  Perhaps we can test the two 
separately?  In particular, we can remove the atomic list effects by just 
having Event::cancel_event() call cancel_action() and commenting out the call 
to process_cancelled_events().

Leif, you up for running your test again with that change?


                
> apply time-wheel scheduler  about event system
> ----------------------------------------------
>
>                 Key: TS-1405
>                 URL: https://issues.apache.org/jira/browse/TS-1405
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 3.2.0
>            Reporter: Bin Chen
>            Assignee: Bin Chen
>             Fix For: 3.3.2
>
>         Attachments: linux_time_wheel.patch, linux_time_wheel_v10jp.patch, 
> linux_time_wheel_v11jp.patch, linux_time_wheel_v2.patch, 
> linux_time_wheel_v3.patch, linux_time_wheel_v4.patch, 
> linux_time_wheel_v5.patch, linux_time_wheel_v6.patch, 
> linux_time_wheel_v7.patch, linux_time_wheel_v8.patch, 
> linux_time_wheel_v9jp.patch
>
>
> when have more and more event in event system scheduler, it's worse. This is 
> the reason why we use inactivecop to handler keepalive. the new scheduler is 
> time-wheel. It's have better time complexity(O(1))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to