[ 
https://issues.apache.org/jira/browse/TS-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-1729:
------------------------------

    Attachment: TS-1729.diff

here's a proposed "stop-gap" fix. It changes things to use proper IPv4 only 
types etc. Yes, I know this is not the right thing to do for IPv4 *and* IPv6 
compatibility. But the plugin was already IPv4 only as far as I could tell.

Bryan, any thoughts?
                
> channel_stats does not compile on Solaris 10
> --------------------------------------------
>
>                 Key: TS-1729
>                 URL: https://issues.apache.org/jira/browse/TS-1729
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build, Plugins
>            Reporter: Igor Galić
>            Assignee: Igor Galić
>             Fix For: 3.3.3
>
>         Attachments: channel_stats.patch, TS-1729.diff
>
>
> {noformat}
> gmake[3]: Entering directory 
> `/export/home/buildbot/slave5/tserver-solaris-trunk/build/plugins/experimental/channel_stats'
>   CXX      channel_stats.lo
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>::<anonymous struct>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>::<anonymous struct>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>::<anonymous struct>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>::<anonymous struct>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>::<anonymous struct>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>::<anonymous struct>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>::<anonymous struct>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>' [-Werror=missing-braces]
> channel_stats.cc:128:1: error: missing braces around initializer for 
> 'in_addr::<anonymous union>::<anonymous struct>' [-Werror=missing-braces]
> channel_stats.cc:124:25: error: narrowing conversion of 'inet_addr(((const 
> char*)"10.0.0.0"))' from 'in_addr_t {aka unsigned int}' to 'uint8_t {aka 
> unsigned char}' inside { } [-Werror=narrowing]
> channel_stats.cc:124:51: error: narrowing conversion of 'inet_addr(((const 
> char*)"255.0.0.0"))' from 'in_addr_t {aka unsigned int}' to 'uint8_t {aka 
> unsigned char}' inside { } [-Werror=narrowing]
> channel_stats.cc:125:26: error: narrowing conversion of 'inet_addr(((const 
> char*)"127.0.0.0"))' from 'in_addr_t {aka unsigned int}' to 'uint8_t {aka 
> unsigned char}' inside { } [-Werror=narrowing]
> channel_stats.cc:125:52: error: narrowing conversion of 'inet_addr(((const 
> char*)"255.0.0.0"))' from 'in_addr_t {aka unsigned int}' to 'uint8_t {aka 
> unsigned char}' inside { } [-Werror=narrowing]
> channel_stats.cc:126:27: error: narrowing conversion of 'inet_addr(((const 
> char*)"172.16.0.0"))' from 'in_addr_t {aka unsigned int}' to 'uint8_t {aka 
> unsigned char}' inside { } [-Werror=narrowing]
> channel_stats.cc:126:55: error: narrowing conversion of 'inet_addr(((const 
> char*)"255.240.0.0"))' from 'in_addr_t {aka unsigned int}' to 'uint8_t {aka 
> unsigned char}' inside { } [-Werror=narrowing]
> channel_stats.cc:127:28: error: narrowing conversion of 'inet_addr(((const 
> char*)"192.168.0.0"))' from 'in_addr_t {aka unsigned int}' to 'uint8_t {aka 
> unsigned char}' inside { } [-Werror=narrowing]
> channel_stats.cc:127:56: error: narrowing conversion of 'inet_addr(((const 
> char*)"255.255.0.0"))' from 'in_addr_t {aka unsigned int}' to 'uint8_t {aka 
> unsigned char}' inside { } [-Werror=narrowing]
> cc1plus: all warnings being treated as errors
> gmake[3]: *** [channel_stats.lo] Error 1
> gmake[3]: Leaving directory 
> `/export/home/buildbot/slave5/tserver-solaris-trunk/build/plugins/experimental/channel_stats'
> gmake[2]: *** [all-recursive] Error 1
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to