[ 
https://issues.apache.org/jira/browse/TS-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655589#comment-13655589
 ] 

Yunkai Zhang edited comment on TS-1891 at 5/12/13 6:02 PM:
-----------------------------------------------------------

[~jamespeach]:

1) Use a char refcount instead of a single bit, just for easy implementation -- 
there are no bit array in C/C++(The std::bitset is too slow for us, std::bitset 
is eight times less than the smallest elemental type in C++: char, see: 
http://www.cplusplus.com/reference/bitset/bitset/). Use char array is simple 
and fast to access.

2) The original freelist has had double-free checking feature.

3) Use option for performance reason:
   3.1) the option can be updated online by traffic_line -x. So it's easy to 
use. And
   3.2) in the original freelist, the double-free checking is also disable by 
default.
                
      was (Author: yunkai):
    [~jamespeach]:

1) Use a char refcount instead of a single bit, just for easy implementation -- 
there are no bit array in C/C++. Use char array is simple and fast to access.

2) The original freelist has had double-free checking feature.

3) Use option for performance reason:
   3.1) the option can be updated online by traffic_line -x. So it's easy to 
use. And
   3.2) in the original freelist, the double-free checking is also disable by 
default.

                  
> Add double-free checking for reclaimable freelist
> -------------------------------------------------
>
>                 Key: TS-1891
>                 URL: https://issues.apache.org/jira/browse/TS-1891
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Yunkai Zhang
>         Attachments: 
> 0001-Add-double-free-checking-for-reclaimable-freelist-V2.patch
>
>
> double-free checking is very useful for us to analyze memory issues.
> So, I introduce this feature to recalimable freelist.
> The double-free checking for reclaimable freelist is disable by default,
> users can enable it by setting the following option in records.config:
> {code}
>   CONFIG proxy.config.allocator.check_double_free INT 1
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to