[
https://issues.apache.org/jira/browse/TS-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669573#comment-13669573
]
ASF subversion and git services commented on TS-1825:
-----------------------------------------------------
Commit 8ed70b69b00d277c35fc20c6de46ebef974a2d51 in branch refs/heads/master
from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=8ed70b6 ]
TS-1825: TSPortDescriptorAccept does not use it's argument
TSPortDescriptorAccept never calls the acceptance continuation that
it takes as an argument. Fix TSPortDescriptorAccept so that it
actually uses the continuation from the caller. Fix the corresponding
unit test.
Refactor the SDK_API_TSNetVConn and SDK_API_TSPortDescriptor tests
and update the them so that them actually verify the connection on
the server side. Generalize them to not use any global variables.
over
> TSPortDescriptorAccept() does not use its TSCont contp parameter
> ----------------------------------------------------------------
>
> Key: TS-1825
> URL: https://issues.apache.org/jira/browse/TS-1825
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Reporter: Leif Hedstrom
> Assignee: James Peach
> Priority: Blocker
> Fix For: 3.3.3
>
>
> This looks odd:
> {code}
> TSReturnCode
> TSPortDescriptorAccept(TSPortDescriptor descp, TSCont contp)
> {
> HttpProxyPort * port = (HttpProxyPort *)descp;
> return start_HttpProxyPort(*port, 0 /* nthreads */) ? TS_SUCCESS : TS_ERROR;
> }
> {code}
> Assuming that (as per the IRC discussions) TSPortDescriptAccept() should work
> something similar to TSNetAccept, shouldn't it be using the contp for
> callbacks?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
