[ 
https://issues.apache.org/jira/browse/TS-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726991#comment-13726991
 ] 

ASF subversion and git services commented on TS-1953:
-----------------------------------------------------

Commit 5b8b96850137ed29905fd1c244b4c6da3a3b02e2 in branch refs/heads/master 
from [~i.galic]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5b8b968 ]

TS-1953: remove check_ts_version() from examples

remove the boilerplate check_ts_version() function call from all
examples. This function is nice in a specific example, but it does not
make sense to have it in every single example plugin.

Since the code is compiled, in most cases that's too late to catch
issues with API versions, so it doesn't make sense to begin with.
In order to enable Plugin Developers to do such checks, and #ifdef
around API issues, we'd have to expose the TS_VERSION_* contants.

n.b.: We might want add one example which shows off how to use the
TSTrafficServerGetVersion() API, but we have that in the man page now
anyway.

                
> remove check_ts_version() from (example) plugins or make it an API
> ------------------------------------------------------------------
>
>                 Key: TS-1953
>                 URL: https://issues.apache.org/jira/browse/TS-1953
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Plugins
>            Reporter: Igor Galić
>             Fix For: sometime
>
>
> almost every single of our (example) plugins has a function 
> {{chec_ts_version()}}. If this boiler-code is so crucial to a plugin's 
> functionality, we should offer an API for it, instead of making developers 
> write (copy) that code every time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to